Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added colab link in the Read me for artefact detection #755

Merged
merged 2 commits into from
Dec 25, 2021

Conversation

SiddhantBahuguna
Copy link
Contributor

This PR adds a new row containing the colab link in Readme for plotting the artefact detection predictions.

Any feedback is welcome!

@SiddhantBahuguna SiddhantBahuguna added the ext: notebooks Related to notebooks folder label Dec 25, 2021
@SiddhantBahuguna SiddhantBahuguna self-assigned this Dec 25, 2021
@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #755 (ef7e155) into main (45e1647) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   96.20%   96.08%   -0.13%     
==========================================
  Files         129      129              
  Lines        4799     4799              
==========================================
- Hits         4617     4611       -6     
- Misses        182      188       +6     
Flag Coverage Δ
unittests 96.08% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/_utils.py 94.50% <0.00%> (-4.40%) ⬇️
doctr/models/builder.py 97.36% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e1647...ef7e155. Read the comment docs.

@fg-mindee fg-mindee linked an issue Dec 25, 2021 that may be closed by this pull request
@fg-mindee fg-mindee added the topic: documentation Improvements or additions to documentation label Dec 25, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo to fix and we're good to go!

notebooks/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!

@SiddhantBahuguna
Copy link
Contributor Author

I am unable to merge this branch as not all required tests are passed
tests / pytest-torch (ubuntu-latest, 3.7) (pull_request) >> FAILED\ tests/pytorch/test_models_detection_pt.py::test_detection_models[linknet_resnet18-input_shape3-output_size3-False]

@fg-mindee
Copy link
Contributor

I am unable to merge this branch as not all required tests are passed tests / pytest-torch (ubuntu-latest, 3.7) (pull_request) >> FAILED\ tests/pytorch/test_models_detection_pt.py::test_detection_models[linknet_resnet18-input_shape3-output_size3-False]

I just rerun the unittests, it's one random defect in our unittest that I still haven't solved yet 😅

@fg-mindee
Copy link
Contributor

All good now @SiddhantBahuguna 👍

@SiddhantBahuguna
Copy link
Contributor Author

All good now @SiddhantBahuguna +1

Thanks a lot :)

@SiddhantBahuguna SiddhantBahuguna merged commit a86f8f5 into main Dec 25, 2021
@fg-mindee fg-mindee deleted the notebook_artefact branch December 25, 2021 23:56
@fg-mindee fg-mindee added the type: new feature New feature label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: notebooks Related to notebooks folder topic: documentation Improvements or additions to documentation type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[notebooks] Add a notebook tutorial on artefact detection
2 participants