Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Part 2 from use datasets for recognition #891

Merged
merged 26 commits into from
Apr 27, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Apr 13, 2022

This PR:

  • enables all datasets to be used for recognition task (without obj_detection one)

  • add corresponding tests

  • one special case: SynthText (to big will lead to memory overflow) -> saved in cache for faster reload and avoiding memory explosions 馃槄

  • all other works fine without caching

Issues:
Closes #867
(Documentation for this will follow in another PR #855 )

Any feedback is welcome 馃

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #891 (ab2b437) into main (1a4e4df) will increase coverage by 0.00%.
The diff coverage is 98.48%.

@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   94.71%   94.72%           
=======================================
  Files         135      135           
  Lines        5375     5440   +65     
=======================================
+ Hits         5091     5153   +62     
- Misses        284      287    +3     
Flag Coverage 螖
unittests 94.72% <98.48%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/datasets/synthtext.py 94.73% <92.59%> (-2.41%) 猬囷笍
doctr/datasets/cord.py 97.72% <100.00%> (+0.29%) 猬嗭笍
doctr/datasets/funsd.py 97.36% <100.00%> (+0.39%) 猬嗭笍
doctr/datasets/ic03.py 97.72% <100.00%> (+0.35%) 猬嗭笍
doctr/datasets/ic13.py 96.77% <100.00%> (+0.62%) 猬嗭笍
doctr/datasets/iiit5k.py 96.96% <100.00%> (+0.19%) 猬嗭笍
doctr/datasets/imgur5k.py 93.33% <100.00%> (+0.83%) 猬嗭笍
doctr/datasets/sroie.py 97.29% <100.00%> (+0.42%) 猬嗭笍
doctr/datasets/svhn.py 95.23% <100.00%> (+0.50%) 猬嗭笍
doctr/datasets/svt.py 97.61% <100.00%> (+0.39%) 猬嗭笍
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1a4e4df...ab2b437. Read the comment docs.

@felixdittrich92
Copy link
Contributor Author

@charlesmindee wdyt?

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 624ee6c into mindee:main Apr 27, 2022
@felixdittrich92 felixdittrich92 deleted the crop-2 branch April 27, 2022 19:40
@frgfm frgfm added ext: tests Related to tests folder module: datasets Related to doctr.datasets type: new feature New feature labels May 2, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 28, 2022
@felixdittrich92 felixdittrich92 mentioned this pull request Jun 29, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants