-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Part 2 from use datasets for recognition #891
Conversation
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
=======================================
Coverage 94.71% 94.72%
=======================================
Files 135 135
Lines 5375 5440 +65
=======================================
+ Hits 5091 5153 +62
- Misses 284 287 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@charlesmindee wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR:
enables all datasets to be used for recognition task (without obj_detection one)
add corresponding tests
one special case: SynthText (to big will lead to memory overflow) -> saved in cache for faster reload and avoiding memory explosions 😅
all other works fine without caching
Issues:
Closes #867
(Documentation for this will follow in another PR #855 )
Any feedback is welcome 🤗