Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[references] Add eval recognition and update eval detection scripts #933

Merged
merged 5 commits into from
Jun 13, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented May 29, 2022

This PR contains:

  • ensure all crops are RGB
  • updates detection eval scripts
  • adds recognition eval scripts
  • add CI jobs for recognition and detection evaluation scripts

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text recognition Related to the task of text recognition labels May 29, 2022
@felixdittrich92 felixdittrich92 self-assigned this May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #933 (c57c3d3) into main (0c8dd60) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   94.68%   94.70%   +0.01%     
==========================================
  Files         134      134              
  Lines        5491     5491              
==========================================
+ Hits         5199     5200       +1     
+ Misses        292      291       -1     
Flag Coverage Δ
unittests 94.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/utils.py 93.33% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)
doctr/transforms/functional/base.py 97.10% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8dd60...c57c3d3. Read the comment docs.

@felixdittrich92 felixdittrich92 marked this pull request as draft May 29, 2022 15:36
@felixdittrich92 felixdittrich92 changed the title [references] add recognition eval scripts PT/TF [references] Add eval recognition and update eval detection scripts May 29, 2022
@felixdittrich92 felixdittrich92 added the topic: text detection Related to the task of text detection label May 29, 2022
@felixdittrich92 felixdittrich92 marked this pull request as ready for review May 29, 2022 19:57
@felixdittrich92
Copy link
Contributor Author

@frgfm maybe some time to review ? :octocat:

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 210ecc4 into mindee:main Jun 13, 2022
@felixdittrich92 felixdittrich92 deleted the val-reco branch June 13, 2022 11:58
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late review, but that's nice 👍

I just figured that I forgot to open a PR for a similar work I had done months ago 🙃

@felixdittrich92
Copy link
Contributor Author

Late review, but that's nice +1

I just figured that I forgot to open a PR for a similar work I had done months ago upside_down_face

😅 good to have it done now :) But we need to update the current CI job for this it takes to long and to much resources

@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 29, 2022
@felixdittrich92 felixdittrich92 mentioned this pull request Jun 29, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants