Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in readme #937

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fix links in readme #937

merged 1 commit into from
Jun 1, 2022

Conversation

jsn5
Copy link
Contributor

@jsn5 jsn5 commented Jun 1, 2022

Fix links to text detection and text recognition in readme

Fix links to text detection and text recognition
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot 🙏

@frgfm frgfm self-assigned this Jun 1, 2022
@frgfm frgfm added type: bug Something isn't working topic: documentation Improvements or additions to documentation labels Jun 1, 2022
@frgfm frgfm added this to the 0.5.2 milestone Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #937 (8c52d47) into main (75531c5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   94.71%   94.72%   +0.01%     
==========================================
  Files         134      134              
  Lines        5501     5501              
==========================================
+ Hits         5210     5211       +1     
+ Misses        291      290       -1     
Flag Coverage Δ
unittests 94.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)
doctr/transforms/functional/base.py 97.10% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75531c5...8c52d47. Read the comment docs.

@felixdittrich92 felixdittrich92 merged commit 7983de2 into mindee:main Jun 1, 2022
@frgfm
Copy link
Collaborator

frgfm commented Jun 1, 2022

@felixdittrich92 better to edit the commit message next time before merging 😉
Something like "docs: Fixed URLs in README"

@felixdittrich92
Copy link
Contributor

@frgfm we should maybe at a short note about commit messages before merging in the wiki like:
type: short description about the commit wdyt ?

@frgfm
Copy link
Collaborator

frgfm commented Jun 1, 2022

@felixdittrich92 there is a section in contributing https://github.com/mindee/doctr/blob/main/CONTRIBUTING.md#commits
but perhaps it's too subtle 🤷

@jsn5 jsn5 deleted the patch-1 branch June 2, 2022 05:47
@frgfm frgfm mentioned this pull request Jun 28, 2022
14 tasks
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
@felixdittrich92 felixdittrich92 modified the milestones: 0.5.2, 0.6.0 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants