Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowed locations (whitelist) for STRICT mode #224

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Add allowed locations (whitelist) for STRICT mode #224

merged 9 commits into from
Feb 6, 2024

Conversation

mindflayer
Copy link
Owner

@mindflayer mindflayer commented Feb 5, 2024 •
edited
Loading

Thanks to @ento for their amazing contributions.

Fix for #218.

@mindflayer
Copy link
Owner Author

Hi @ento, do you want to have a look at my changes before I merge them?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 5, 2024 •
edited
Loading

Coverage Status

coverage: 98.811% (+0.1%) from 98.668%
when pulling 324845f on chore/review-pr
into 6d861c2 on main.

@mindflayer mindflayer merged commit 4bd3e4f into main Feb 6, 2024
10 of 11 checks passed
@mindflayer mindflayer deleted the chore/review-pr branch February 6, 2024 10:19
@ento
Copy link
Collaborator

ento commented Feb 7, 2024

Looks good, thanks for the tidying-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindflayer @coveralls @ento