Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project and change database materialization #27

Merged
merged 2 commits into from
May 23, 2023
Merged

Use project and change database materialization #27

merged 2 commits into from
May 23, 2023

Conversation

bachng2017
Copy link
Contributor

We propose some enhances and changes in this PR

  • add support to PROJECT (https://docs.mindsdb.com/sql/project). User could use project or schema in the dbt profile to specify the mindsDB PJ. One dbt project is supposed to be correspond to one mindsDB project. When the project (schema) does not exist, it will be created automatically.
  • to reduce the confusion, change the database materialization to integration (no logic change)
  • other changes:
    • increase version to 1.0.3
    • update unit test
    • update README

ZoranPandovski
ZoranPandovski approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks

@ZoranPandovski ZoranPandovski merged commit e358339 into mindsdb:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoranPandovski ZoranPandovski ZoranPandovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bachng2017 @ZoranPandovski