Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move evaluation logic into separate package #1089

Merged
merged 6 commits into from
Jan 6, 2023
Merged

[Refactor] Move evaluation logic into separate package #1089

merged 6 commits into from
Jan 6, 2023

Conversation

paxcema
Copy link
Contributor

@paxcema paxcema commented Jan 5, 2023

Why

To fix #1000.

How

Move relevant logic into the new package. Additionally:

  • Moved unit test for imputers to dataprep_ml
  • Deleted some (very old) and unused helpers for text encoding
  • Moved a couple of TS-related accuracy tests into new evaluations package

@paxcema paxcema marked this pull request as ready for review January 5, 2023 22:38
@paxcema paxcema merged commit 57b08e7 into staging Jan 6, 2023
@paxcema paxcema mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move / merge model evaluation into separate library
1 participant
@paxcema