add logger module #180
Merged
add logger module #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamitHuang
reviewed
Apr 14, 2023
configs/rec/crnn/crnn_icdar15.yaml
Outdated
| @@ -69,6 +69,7 @@ loss_scaler: | |||
|
|
|||
| train: | |||
| ckpt_save_dir: './tmp_rec' | |||
| log_interval: 100 | |||
There was a problem hiding this comment.
log_interval参数放到system下。
mindocr/utils/callbacks.py
Outdated
| def __init__(self, | ||
| network, | ||
| epoch_size, |
There was a problem hiding this comment.
不用传epoch_size，这个callback内部可通过cb_params.epoch_num获取
另外，命名保持一致: num_epochs
tools/train.py
Outdated
| main_indicator=cfg.metric.main_indicator, | ||
| val_interval=cfg.system.get('val_interval', 1), | ||
| val_start_epoch=cfg.system.get('val_start_epoch', 1), | ||
| log_interval=cfg.train.log_interval, |
There was a problem hiding this comment.
log_interval 加一个默认值 ，cfg.system.get('log_interval', 100)
configs/rec/crnn/crnn_resnet34.yaml
Outdated
| @@ -69,6 +69,7 @@ loss_scaler: | |||
|
|
|||
| train: | |||
| ckpt_save_dir: './tmp_rec' | |||
| log_interval: 100 | |||
There was a problem hiding this comment.
检测数据比较小，设置为100 step_end日志信息就没法输出
configs/rec/crnn/crnn_vgg7.yaml
Outdated
| @@ -69,6 +69,7 @@ loss_scaler: | |||
|
|
|||
| train: | |||
| ckpt_save_dir: './tmp_rec' | |||
| log_interval: 100 | |||
mindocr/utils/callbacks.py
Outdated
| def __init__(self, | ||
| network, | ||
| epoch_size, | ||
| batch_size, | ||
| logger, |
There was a problem hiding this comment.
batch_size和logger这两个参数放在后面（按重要性和必要性排）
There was a problem hiding this comment.
logger和batch_size是必须传的参数, 训练日志用logger输出，计算fps需要batch_size
There was a problem hiding this comment.
请添加logger的单元测试代码至tests/ut中。
MaigeWhite
force-pushed
the
main
branch
9 times, most recently
from
ec918ee
to
a96fe49
Compare
SamitHuang
reviewed
Apr 19, 2023
tools/train.py
Outdated
| print('='*40) | ||
| logger.info('=' * 40) | ||
| logger.info( | ||
| f'Num devices: {device_num if device_num is not None else 1}\n' |
There was a problem hiding this comment.
这部分log信息有缺失，请与最新的commit同步。
| @@ -3,6 +3,7 @@ system: | |||
| distribute: False | |||
| amp_level: 'O0' | |||
| seed: 42 | |||
| log_interval: 100 | |||
| @@ -3,6 +3,7 @@ system: | |||
| distribute: True | |||
| amp_level: 'O3' | |||
| seed: 42 | |||
| log_interval: 100 | |||
| @@ -3,6 +3,7 @@ system: | |||
| distribute: True | |||
| amp_level: 'O3' | |||
| seed: 42 | |||
| log_interval: 100 | |||
| @@ -3,6 +3,7 @@ system: | |||
| distribute: True | |||
| amp_level: 'O0' | |||
| seed: 42 | |||
| log_interval: 100 | |||
SamitHuang
approved these changes
Apr 19, 2023
colawyee
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)