Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API docstring for psenet #434

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

VictorHe-1
Copy link
Collaborator

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

Add API docstring for psenet

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@VictorHe-1 VictorHe-1 requested a review from hadipash June 21, 2023 01:41
Copy link
Collaborator

@hadipash hadipash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good. Maybe later you can update API docs with type hinting as we adopted this standard recently. For example:

def multiplication(num1: int, num2: float) -> float:

@hadipash hadipash merged commit 752bdc7 into mindspore-lab:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants