Develop #39
Merged
Develop #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large portion of coverage on farm.py
Codecov Report
@@ Coverage Diff @@
## develop #39 +/- ##
==========================================
Coverage ? 43.44%
==========================================
Files ? 5
Lines ? 267
Branches ? 38
==========================================
Hits ? 116
Misses ? 141
Partials ? 10 Continue to review full report at Codecov.
|
| @@ -5,12 +5,14 @@ class Farm: | |||
|
|
|||
| def __init__(self, farmerName:str='Farmer', | |||
| cuerdas:float=1, | |||
| treeType:str='Borbon', | |||
| treeType:str='Borbón', | |||
There was a problem hiding this comment.
make sure 'borbon' as an argument behaves the same for those of us without convenient access to accents on keyboards ;D
| self.farmerName = farmerName | ||
|
|
||
| self.inheretTreeProperties(treeType) | ||
| self.inheretTreeProperties(treeType, treeAttributes) |
| # as soon as yaml imports are tested, this can be deleted: | ||
| # temporary stand-in for variable testing | ||
| else: | ||
| if (treeType =='borbon') or (treeType == 'borbón'): |
There was a problem hiding this comment.
use the str library or something similar to standardize stripping/formatting instead of trying to catch this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
large portion of farm.py is covered & passing