Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to place armor on anvil #19

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fix not being able to place armor on anvil #19

merged 2 commits into from
Oct 1, 2020

Conversation

OgelGames
Copy link

No description provided.

@SmallJoker
Copy link
Member

Placing armor to equip it seems to be a feature when you're in a rush (PvP arena or so).
What do you think about this approach:

  • if the pointed node has a on_rightclick callback -> call it
  • if the pointed node has no on_rightclick or "Sneak" is pressed -> equip armor

That's a common practice to switch between actions for tools that can also be put into chests directly.

@OgelGames
Copy link
Author

@SmallJoker I didn't think it was necessary to have a check for on_rightclick, but now that I think of it, it makes sense for equipping armor in a confined space where you can't not point at a node.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Will merge in a few days unless there are objections.

@BuckarooBanzay
Copy link
Member

Works. Will merge in a few days unless there are objections.

LGTM too, i think i'm merging this right now, don't see an issue with it 😋

@BuckarooBanzay BuckarooBanzay merged commit 3f1a952 into minetest-mods:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants