Add support for playerfactions mod #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2019 15:55
Also added faction indicator to HUD
crabctrl
changed the title
SmallJoker
reviewed
Sep 13, 2019
SmallJoker
reviewed
Sep 13, 2019
|
Thanks for the review, the code has been updated accordingly |
SmallJoker
reviewed
Sep 13, 2019
Renamed factions_avail to areas.factions_available
|
I've updated the code yet again; thank you for your patience |
|
Will merge in a few days to see whether any other change requests appear. |
|
It's been a cool three days now; time to merge? |
SmallJoker
reviewed
Sep 18, 2019
SmallJoker
reviewed
Sep 18, 2019
SmallJoker
reviewed
Sep 21, 2019
SmallJoker
reviewed
Sep 21, 2019
SmallJoker
reviewed
Sep 21, 2019
SmallJoker
approved these changes
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm still pretty new to Minetest mod development in general so please correct me if I'm going about this wrong.
Frustrated by the lack of a way to manage allowing large groups of people to access certain areas, I've developed a
factionsmod which allows players to create and invite each other to factions. There's currently some room for improvement within thefactionsmod itself, but it is functional in its current state.I've written some patches for the
areasmod to allow players to control access to their areas using factions. It's an optional dependency of course, so existing users are completely unaffected. Specifically, it adds one command,/area_faction_open <ID>, which functions exactly the same as/area_open <ID>except that it opens/closes the area to faction members only.I've done some testing on my own, and it seems to work fine. If somebody else would like to test it I'll be happy to help in any way I can. The actual factions mod can be found here.
Thanks for your time!