Add platform dependent download link #94
Conversation
rubenwardy
force-pushed
the
download-detect
branch
2 times, most recently
from
8e1c435 to
0ce879a
Compare
|
that reminds me we should really do flatpak builds, and advertise those as well. |
rubenwardy
force-pushed
the
download-detect
branch
2 times, most recently
from
57757c2 to
f2a42f1
Compare
|
@sofar in the case you were not aware, there are already unofficial flatpak builds at the forum: https://forum.minetest.net/viewtopic.php?f=42&t=15336 Github link: https://github.com/est31/minetest-flatpak What's missing is three things:
I hoped flathub would have became a thing, but seems nothing is happening here, so we'll have to roll our own. :/ |
downloads.html
Outdated
| title = "{{ page.latest_downloads.mac.title }}"; | ||
| url = "{{ page.latest_downloads.mac.url }}"; | ||
| } else if (platform.indexOf("linux") >= 0) { | ||
| platform_name = "Ubuntu"; |
There was a problem hiding this comment.
TRIGGERED
I mean this is pretty stupid, most browsers on Ubuntu even have that in the user agent so you could look for that. Don't even bother trying to add a download button for the other linux flavors
There was a problem hiding this comment.
I think we should instead redirect to the download page in the case of linux.
There was a problem hiding this comment.
It's a good guess, but yeah - it's on my todo list
rubenwardy
force-pushed
the
download-detect
branch
from
f2a42f1 to
0baec0c
Compare
|
updated |
rubenwardy
force-pushed
the
download-detect
branch
5 times, most recently
from
c980c78 to
367a9c9
Compare
downloads.html
Outdated
| <script> | ||
| function detectPlatformName() { | ||
| var userAgent = navigator.userAgent.toLowerCase(); | ||
| var platforms = ["windows", "mac", "ubuntu", "debian", "fedora"]; |
There was a problem hiding this comment.
is fedora or debian actually found in user agents?
afaik only ubuntu does this
There was a problem hiding this comment.
| ubuntu: | ||
| os: Ubuntu | ||
| title: search for .deb | ||
| url: http://packages.ubuntu.com/search?keywords=minetest |
There was a problem hiding this comment.
might be better to link to the software center:
https://apps.ubuntu.com/cat/applications/minetest/ or a link that would open the "software center" application
downloads.html
Outdated
| debian: | ||
| os: Debian | ||
| title: search for .deb | ||
| url: https://packages.debian.org/search?keywords=minetest |
There was a problem hiding this comment.
how do we deal with debian & ubuntu mostly having ridiculously outdated versions?
There was a problem hiding this comment.
No idea :/
Maybe detect whether the OS is LTS or not for Ubuntu?
Or get the user to install a stable MT apt repo
There was a problem hiding this comment.
It's worth noting that I literally copied the links from the Linux section, and this problem existed before. There's just less text now to warn them
rubenwardy
force-pushed
the
download-detect
branch
2 times, most recently
from
5bfc25e to
81eb318
Compare
|
added all Linux platforms in the linux section, although I have no idea if they work (yet) :P |
rubenwardy
force-pushed
the
download-detect
branch
4 times, most recently
from
7b03b6f to
80afc99
Compare
rubenwardy
force-pushed
the
download-detect
branch
from
80afc99 to
13625ce
Compare
|
Updated. Worrying about old versions existed before this PR. I think this should be solved in a separate PR by adding apt-repo instructions. |
rubenwardy
force-pushed
the
download-detect
branch
from
13625ce to
686b543
Compare
|
I think we should go the same path big browsers are going.
|
|
Should be For arch, as its generally up to date. |
|
For Elementary OS it could automatically open in the App Store. Like this: https://appcenter.elementary.io/minetest.desktop I am not sure how it would identify Elementary OS users. |
Make Ubuntu link open in software center1 = https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/operating-system-name/linux-user-agents