Add ability to escape commands with a back-slash #1768

ShadowNinja · 2014-10-24T18:46:31Z

Rationale: Useful when telling a user to run a specific command.

Older clients will see the back slash on their display when they send a message, and older servers will show the backslash on all other displays.

sfan5 · 2014-10-25T05:58:05Z

👎
We don't need this, typing " /some_command" works too and everyone does this.
Just because you chose the double-forward-slash escape because that's how my IRC client does it doesn't mean everyone else wants that.

SmallJoker · 2014-10-25T16:49:36Z

👎 Same reason as sfan5

ShadowNinja · 2014-10-25T18:14:56Z

@sfan5: That prepends a space to your message though. I don't think IRC clients use this method while all of their users want a different method, they didn't just chose a random method. The fact that this is in IRC clients means that users want it and find that this method is a good way to escape it.

Calinou · 2014-10-25T20:04:42Z

👍

It makes sense, many IRC clients do that already.

kaeza · 2014-10-26T02:34:48Z

👍

Apart from Calinou's reason, it adds a way to discourage silly command names like WE had.

ghost · 2014-10-26T03:48:32Z

I'd much prefer the ./command style, for some reason it just feels better. Then again, I've probably played too much MC.

Calinou · 2014-10-26T17:51:54Z

./command looks bad and looks like you forced yourself some random workaround.

sfan5 · 2014-10-30T09:35:38Z

@sfan5: That prepends a space to your message though.

Holy shit. a space. What is so bad about a space?

ShadowNinja · 2014-10-30T21:14:26Z

@sfan5: It's a hack, a workaround rather than a proper fix.

est31 · 2015-03-01T00:03:27Z

I'm for backslash \ as escape character. Double slash would break worldedit and is inconsistent with most programming languages.

ShadowNinja · 2015-08-24T17:41:54Z

Rebased and changed to back-slash.

est31 · 2015-08-24T21:47:49Z

👍

sfan5 · 2015-08-29T19:36:16Z

src/client.cpp

 		LocalPlayer *player = m_env.getLocalPlayer();
 		assert(player != NULL);
 		std::wstring name = narrow_to_wide(player->getName());
-		m_chat_queue.push((std::wstring)L"<" + name + L"> " + message);
+		m_chat_queue.push((std::wstring)L"<" + name + L"> " +
+			(message[0] == L'\\' ? message.substr(1) : message));


Actually this code does not do what the description says.
Currently if I were to type in "\foobar" it would get changed to "foobar".
What this is supposed to do is "\/foobar" -> "/foobar" and only that.

est31 · 2016-03-18T04:01:43Z

@paramat there is one disapproval by @sfan5 makes 0 approvals in total (or one if SN approves)

paramat · 2016-03-18T04:08:13Z

Okay, but i doubt we add them up like that, 2 approvals remain 2 approvals despite dissapprovals.

ShadowNinja · 2016-03-20T04:14:40Z

I have to fix the bit sfan5 reported before this is ready. It's fairly trivial, I've just been busy with other things.

0-afflatus · 2016-03-20T19:58:51Z

I'm with @sfan5 on this, but I guess I could live with it. Non-issue for me.

paramat · 2016-10-27T09:14:43Z

@ShadowNinja ?

ShadowNinja · 2016-10-30T01:25:00Z

Sorry, I still don't have much time for this. Someone else could fix this quite easily and merge it since it's already approved.

sfan5 · 2016-10-30T10:25:41Z

since it's already approved.

disapprovals don't count anymore?

ShadowNinja · 2016-11-22T04:10:23Z

Er, I'm not sure what it adds up to.

paramat · 2016-11-25T05:41:39Z

Disapprovals don't subtract from approvals, so this technically has 2 approvals, counting one from the core dev author. However it is good dev practice to address objections.

HybridDog · 2017-04-11T09:25:42Z

Players shouldn't make the command be shown as their chat message just to tell other players how to use the command.
Also, adding a space before the command is a lot easier than \ (on qwertz keyboards, that is) and players don't become baffled because of not knowing how other players can write the command without being executed.
It also confuses modders because the chat message which is shown is not the same as the string in lua.

nerzhul · 2017-04-11T22:36:36Z

@HybridDog adding space is what i do on... skype, IRC, gitlab, slack... everywhere, and it's more natural

ShadowNinja added @ Script API low-priority enhancement labels Oct 24, 2014

ShadowNinja mentioned this pull request Oct 24, 2014

Use "we-" prefix for commands Uberi/Minetest-WorldEdit#62

Merged

Zeno- force-pushed the master branch from 2642ca4 to a1db83e Compare November 25, 2014 02:39

kwolekr force-pushed the master branch from decd9c5 to 3f83ca2 Compare December 25, 2014 03:28

ShadowNinja added enhancement Low priority and removed low-priority enhancement labels Mar 1, 2015

est31 force-pushed the master branch from 1f1fb21 to a890c66 Compare August 2, 2015 17:10

Add ability to escape commands with a back-slash

59e0ad1

ShadowNinja force-pushed the command-escape branch from 0943561 to 59e0ad1 Compare August 24, 2015 17:41

ShadowNinja changed the title ~~Add ability to escape commands with a second forward-slash~~ Add ability to escape commands with a back-slash Aug 24, 2015

sfan5 reviewed Aug 29, 2015
View reviewed changes

paramat added the One approval ✅ ◻️ label Mar 18, 2016

est31 removed the One approval ✅ ◻️ label Mar 18, 2016

paramat added the WIP label Mar 21, 2016

paramat added the Rebase needed The PR needs to be rebased by its author label Oct 27, 2016

paramat removed the Enhancement label Oct 29, 2016

ShadowNinja added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Oct 30, 2016

paramat added the Adoption needed The pull request needs someone to adopt it. Adoption welcomed! label Oct 30, 2016

paramat added the One approval ✅ ◻️ label Nov 25, 2016

sfan5 force-pushed the master branch from c90b63a to 09f1a0c Compare December 21, 2016 13:13

ShadowNinja closed this Apr 22, 2017

Zughy removed the Adoption needed The pull request needs someone to adopt it. Adoption welcomed! label May 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to escape commands with a back-slash #1768

Add ability to escape commands with a back-slash #1768

ShadowNinja commented Oct 24, 2014

sfan5 commented Oct 25, 2014

SmallJoker commented Oct 25, 2014

ShadowNinja commented Oct 25, 2014

Calinou commented Oct 25, 2014

kaeza commented Oct 26, 2014

ghost commented Oct 26, 2014

Calinou commented Oct 26, 2014

sfan5 commented Oct 30, 2014

ShadowNinja commented Oct 30, 2014

est31 commented Mar 1, 2015

ShadowNinja commented Aug 24, 2015

est31 commented Aug 24, 2015

sfan5 Aug 29, 2015 •

edited

Loading

est31 commented Mar 18, 2016

paramat commented Mar 18, 2016

ShadowNinja commented Mar 20, 2016

0-afflatus commented Mar 20, 2016

paramat commented Oct 27, 2016

ShadowNinja commented Oct 30, 2016

sfan5 commented Oct 30, 2016

ShadowNinja commented Nov 22, 2016

paramat commented Nov 25, 2016

HybridDog commented Apr 11, 2017

nerzhul commented Apr 11, 2017

Add ability to escape commands with a back-slash #1768

Add ability to escape commands with a back-slash #1768

Conversation

ShadowNinja commented Oct 24, 2014

sfan5 commented Oct 25, 2014

SmallJoker commented Oct 25, 2014

ShadowNinja commented Oct 25, 2014

Calinou commented Oct 25, 2014

kaeza commented Oct 26, 2014

ghost commented Oct 26, 2014

Calinou commented Oct 26, 2014

sfan5 commented Oct 30, 2014

ShadowNinja commented Oct 30, 2014

est31 commented Mar 1, 2015

ShadowNinja commented Aug 24, 2015

est31 commented Aug 24, 2015

sfan5 Aug 29, 2015 • edited Loading

Choose a reason for hiding this comment

est31 commented Mar 18, 2016

paramat commented Mar 18, 2016

ShadowNinja commented Mar 20, 2016

0-afflatus commented Mar 20, 2016

paramat commented Oct 27, 2016

ShadowNinja commented Oct 30, 2016

sfan5 commented Oct 30, 2016

ShadowNinja commented Nov 22, 2016

paramat commented Nov 25, 2016

HybridDog commented Apr 11, 2017

nerzhul commented Apr 11, 2017

sfan5 Aug 29, 2015 •

edited

Loading