Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update credits #5800

Closed
wants to merge 7 commits into from
Closed

Update credits #5800

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
023257a
Update credits
Zeno- May 22, 2017
97a3b23
Update
Zeno- May 23, 2017
922b62f
Remove RBA's email as it's no longer valid
Zeno- May 23, 2017
c012378
Move VanessaE to active
Zeno- May 23, 2017
bc5c814
Add Shara
Zeno- May 23, 2017
c328af5
Update
Zeno- May 24, 2017
772f30d
Move inactive core devs
Zeno- May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions builtin/mainmenu/tab_credits.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,38 +26,39 @@ local core_developers = {
"ShadowNinja <shadowninja@minetest.net>",
"Nathanaël Courant (Nore/Ekdohibs) <nore@mesecons.net>",
"Loic Blot (nerzhul/nrz) <loic.blot@unix-experience.fr>",
"Matt Gregory (paramat)",
"est31 <MTest31@outlook.com>",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com>",
"paramat",
"Craig Robbins (Zeno) <craig.d.robbins@gmail.com> (Dancing Queen)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untrue statement. You might feel like a queen and dance but this doesn't make you to a queen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest Dancing Person feeling like a Queen or Dancing Pseudoqueen or Dancing Quasiqueen.

"Auke Kok (sofar) <sofar@foo-projects.org>",
"Andrew Ward (rubenwardy) <rubenwardy@gmail.com>",
"SmallJoker <mk939@ymail.com>",
}

local active_contributors = {
"Duane Robertson <duane@duanerobertson.com>",
"SmallJoker <mk939@ymail.com>",
"Lars Hofhansl <larsh@apache.org>",
"Jeija <jeija@mesecons.net>",
"Gregory Currie (gregorycu)",
"Sokomine <wegwerf@anarres.dyndns.org>",
"TeTpaAka",
"Jean-Patrick G (kilbith) <jeanpatrick.guerrero@gmail.com>",
"Diego Martínez (kaeza) <kaeza@users.sf.net>",
"Dániel Juhász (juhdanad) <juhdanad@gmail.com>",
"Rogier <rogier777@gmail.com>",
"red-001 <red-001@outlook.ie>",
"Vanessa Ezekowitz (VanessaE) <vanessaezekowitz@gmail.com>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no amount of PR in the core engine, should be removed

Copy link
Contributor Author

@Zeno- Zeno- May 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite often there are PRs that need live testing before they are added to the engine. Often the person who does this is Vanessa, on her actual servers (not "test" servers). To me that is contributing and a valuable one. I don't think Vanessa cares if her name is in this section or not, but I believe it does belong here. Developing is about more than just coding.

Edit: Just so this is clear, I am not going to put my foot down and refuse to move the entry back to where it was. This PR is not going to be merged until just before release though, so it can stay where I've moved it to for now so that it can be /rationally/ discussed. I really do believe that development is more than just coding: consistent and detailed bug reports, testing PRs, writing documentation (amongst many others) are all examples of things that are required and don't involve any programming at all.

"Shara RedCat",
}

local previous_core_developers = {
"BlockMen",
"Maciej Kasatkin (RealBadAngel) <maciej.kasatkin@o2.pl>",
"Maciej Kasatkin (RealBadAngel) <RIP>",
"Lisa Milne (darkrose) <lisa@ltmnet.com>",
"proller",
"Ilya Zhuravlev (xyz) <xyz@minetest.net>",
"PilzAdam <pilzadam@minetest.net>",
"est31 <MTest31@outlook.com>",
}

local previous_contributors = {
"Vanessa Ezekowitz (VanessaE) <vanessaezekowitz@gmail.com>",
"Sokomine <wegwerf@anarres.dyndns.org>",
"Jurgen Doser (doserj) <jurgen.doser@gmail.com>",
"MirceaKitsune <mirceakitsune@gmail.com>",
"dannydark <the_skeleton_of_a_child@yahoo.co.uk>",
Expand All @@ -72,6 +73,7 @@ local previous_contributors = {
"JacobF <queatz@gmail.com>",
"TriBlade9 <triblade9@mail.com>",
"Zefram <zefram@fysh.org>",
"Gregory Currie (gregorycu)",
}

return {
Expand Down