Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dedicated server step to 0.09 #6252

Merged
merged 1 commit into from Aug 17, 2017

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Aug 16, 2017

Minetest performance improvement has been huge since months, server step reduction will permit to handle client events a little bit faster without too many penalty costs due to core engine

I propose to reduce step from 0.10 to 0.09, it also permits to handle 10% more users packets as it seems we handle 1 packet per loop step (i will open a new PR to fix that an optimize it later)

Minetest performance improvement has been huge since months, server step reduction will permit to handle client events a little bit faster without too many penalty costs due to core engine
@nerzhul nerzhul requested a review from a team August 16, 2017 12:28
@nerzhul nerzhul added this to the 0.5.0 milestone Aug 16, 2017
@SmallJoker SmallJoker added the User feedback needed Feedback from players/server owners/modders is needed to determine if the change should be done. label Aug 16, 2017
@nerzhul
Copy link
Member Author

nerzhul commented Aug 16, 2017

@minetest/team-minetest please vote on my upper post by adding 👍 or 👎

@Calinou
Copy link
Member

Calinou commented Aug 16, 2017

Why not 0.05 or perhaps 0.075?

@nerzhul
Copy link
Member Author

nerzhul commented Aug 16, 2017

@Calinou 0.075 can be a good compromise but minetest current core engine is not ready for 0.05, we need more very high level Lua API into core engine permitting to reduce Lua latency/parallelize things to really benefit from it

@sofar
Copy link
Contributor

sofar commented Aug 16, 2017

👍

@nerzhul nerzhul added this to Ready to merge in Minetest 5.0.0 blockers Aug 16, 2017
@nerzhul
Copy link
Member Author

nerzhul commented Aug 16, 2017

merging this as is in 24h if no more comments, 2 approvals

@nerzhul nerzhul merged commit 9bd1887 into minetest:master Aug 17, 2017
@nerzhul nerzhul deleted the reduce_serverstep branch August 17, 2017 17:16
@nerzhul nerzhul moved this from Ready to merge to Done in Minetest 5.0.0 blockers Oct 17, 2017
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
Minetest performance improvement has been huge since months, server step reduction will permit to handle client events a little bit faster without too many penalty costs due to core engine
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
Minetest performance improvement has been huge since months, server step reduction will permit to handle client events a little bit faster without too many penalty costs due to core engine
@grorp grorp removed the request for review from a team October 9, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance >= Two approvals ✅ ✅ User feedback needed Feedback from players/server owners/modders is needed to determine if the change should be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants