Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent furnace messages with invalid recipes #192

Closed
Menche opened this issue Jul 27, 2013 · 9 comments
Closed

Inconsistent furnace messages with invalid recipes #192

Menche opened this issue Jul 27, 2013 · 9 comments

Comments

@Menche
Copy link

Menche commented Jul 27, 2013

When an invalid craft is put into a furnace that has fuel, the furnace continues to say "furnace is empty". When an invalid craft is put into an empty furnace and then fuel is added, the furnace says "furnace is out of fuel" even though it contains a valid fuel.

I think it should say something like "Invalid recipe" instead.

@PilzAdam
Copy link
Contributor

What is an "invalid recipe"?

@EvergreenTheTree
Copy link
Contributor

@PilzAdam He means if you put something like a dirt in the top of the furnace.

@PilzAdam
Copy link
Contributor

PilzAdam commented Dec 6, 2014

I just tested this, and it shows "Furnace is empty" if there is a not cookable item in the top slot and fuel in the bottom slot, and "Furnace out of fuel" if there is no fuel in the bottom slot.
I don't see how this is inconsistent.

@p5yg3n
Copy link
Contributor

p5yg3n commented Dec 6, 2014

I think he means if something not cookable is in the furnace it should say "Item not cookable" or something. And if non-fuel is in fuel slot the furnace should say "Fuel not burnable" or something. Much more informative than "Furnace is empty".

@PilzAdam
Copy link
Contributor

PilzAdam commented Dec 6, 2014

@MT-Modder yea, that would be good. Although it is not possible to place non-fuel in the fuel slot, so that part is not needed ;-)

@p5yg3n
Copy link
Contributor

p5yg3n commented Dec 6, 2014

lol Totally spaced that one :). I'm gonna try to come up with some code for this.

@PilzAdam
Copy link
Contributor

PilzAdam commented Dec 6, 2014

@MT-Modder I already started coding for this....

@p5yg3n
Copy link
Contributor

p5yg3n commented Dec 6, 2014

Okay cool.

@PilzAdam
Copy link
Contributor

PilzAdam commented Dec 7, 2014

5a06de1

@PilzAdam PilzAdam closed this as completed Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants