-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skins #1965
Comments
WIP PR #1967 |
Is it worth discussing which skins to add into the game? |
Probably some shirt color & skin tone variations of Sam/Samantha. |
No it's not worth dicussing, it would be unbearable bikeshedding. |
I made it halfway there to making a databased skins mod but I encountered this issue in the engine. Until we can actually make dynamic textures properly I don't think built-in skins are worth it. |
Some ideas from my site: I think some of the skins handling should be implemented to the new player_api mod, in same way like model. The API enhancement should be usable for all skins provider mods. Maybe the simplest skins provider https://github.com/PilzAdam/player_textures/blob/master/init.lua, should be in player_api, but as function overridable by other mods. This enhancments I see to the player_api (pseudo-code):
The skin definition is at least
next functionality should be in player_api mod
Additional idea: instead of hard-coded "sam" or 1:1 port of https://github.com/PilzAdam/player_textures/blob/master/init.lua as initial skins, just check |
I plan to start to work on proposed changes on player_api and start a new mod called spsp (=Simple Player Skins Provider) with next functionalities:
i think this concept is basic enough and enhanceable by external skins provider mods like skinsdb trough defined API. |
Initial version master...bell07:player_api_skins_spsp open for discussion. The version contains the player_api draft changes at the first, for discussion. Based on this changes I implement spsp-mod mentioned above ... Note the "upright_sprite" is now an registered skin, that means useable in parallel to Sam (for different users), if re-assignment possible by chat command ;-) |
PR #2122 is open for discussion |
Add a simple skins mod
The text was updated successfully, but these errors were encountered: