Add "connected" glass and obsidian glass

[Calinou]

This gives glass and obsidian glass a slight 3D look and make them look “connected” to other nearby nodes of the same type.

Compatibility with older texture packs is kept. Dropped glass looks better and is now 3D.

default_(obsidian_)glass.png: inventory and wield texture, compatible with old texture packs
default_(obsidian_)glass_frame.png: the glass frame
default_(obsidian_)glass_detail.png: the glass detail

[Megaf]

What about a way to give players an option on use or not use connected glass?

[BlockMen]

I agree with Megaf, it should be optional. I wonder if we should change it in the engine and handle it the same way as "fancy trees".

[Calinou]

Use a texture pack: copy default_glass.png, use it as default_glass_detail.png.

Here's, it up to texture packs to do that, no need for a setting.

[BlockMen]

Whether textures connect or not should be handled by settings, not by texture packs. Texturepacks, like the name already says, are ment to define the texture, not the behavior or the shape of nodes. Espacially with something like this. Rendering the framed glass needs more performance than normal glasslike. Another texture doesnt change that.

[Calinou]

Texturepacks, like the name already says, are ment to define the texture, not the behavior or the shape of nodes.

Here, it's the same issue as wanting to disable crack animation (or any other animation, like water or lava – we don't have a setting to disable all texture animations currently). Modifying the texture is enough.

Rendering the framed glass needs more performance than normal glasslike.

Do we have a benchmark that proves rendering glasslike_framed is much slower than glasslike in most cases?

[davisonio]

#193 was created a while ago and is similar to this

[Megaf]

I do like to see the border of glass and I do like the looks of it, I do and so players on my server.
We use glass because we like the look of it.
It is not up to you to decide to change it or not. If it is to add that, so add it as a diferent node.

[Calinou]

If it is to add that, so add it as a diferent node.

Adding it as a different node doesn't make any sense.

[BlockMen]

Made a pull for the engine support. Then the user can decide if he wants connected textures or not.
minetest/minetest#1694

[SmallJoker]

I don't see why a frame texture is needed.

SmallJoker/minibase_game@c15241e16 results in
http://i.imgur.com/goxsKwi.png

[kaeza]

I opened a pull request a while ago for removing inventory_image from the nodedef, but it caused problems with the inventory image. I tested it just again, and these are the results:

Without inventory_image:

With inventory_image:

I'm using a build from 2014-09-19. Has anything changed in the meantime?

[BlockMen]

7f44a49

[paramat]

This doesn't look right, the border around glass is simply the edge of the glass, not the frame, this 3D look glass edge looks like a frame within the glass material and makes the glass look non-glass like.