Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default: Slightly reduce alpha of water post effect colour #735

Closed
wants to merge 1 commit into from
Closed

Default: Slightly reduce alpha of water post effect colour #735

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Dec 7, 2015

"To make water a little clearer and feel purer
Also correct lava alpha values from 192 to 191"

Classic value 64.
Recent value 120 commited by Calinou 6 June 750f957
This commit 103.

I like the recent increase in water alpha and the correction of the colour, but find the post effect colour just a little too dark, murky and hard on the eyes, not quite balanced with how clear and pure the water looks from above.

screenshot_20151207_010305

screenshot_20151207_010255

^ With this commit.

screenshot_20151209_142056

^ Current value.

To make water a little clearer and feel purer
Also correct lava alpha values from 192 to 191
@Calinou
Copy link
Member

Calinou commented Dec 7, 2015

👍

Although we still need more fog to display when in a liquid, for better looks.

@C1ffisme
Copy link

C1ffisme commented Dec 7, 2015

👍 to Calinou's idea.

@paramat
Copy link
Contributor Author

paramat commented Dec 9, 2015

I'm happy you approve Calinou.

@Ekdohibs
Copy link
Member

Ekdohibs commented Dec 9, 2015

Looks good!

@0-afflatus
Copy link

👍 120 was a little too dark

@paramat
Copy link
Contributor Author

paramat commented Dec 12, 2015

@kilbith
Copy link
Contributor

kilbith commented Dec 12, 2015

c66a98b

@HybridDog
Copy link
Contributor

l think you should use only fog instead of just making the screen blue.
It would make it a lot more realistic because you then can't see far, i.e. more fps because of lower view range.

@paramat
Copy link
Contributor Author

paramat commented Dec 13, 2015

No change in light underwater would i think look wrong, so even with closer fog some blue tint would still be needed.

Oops forgot to close c66a98b

@paramat paramat closed this Dec 13, 2015
@HybridDog
Copy link
Contributor

so even with closer fog some blue tint would still be needed.

ln reality if you open your eyes under water with your head near sth, it hurts and you can see the thing and it's not blue.

@0-afflatus
Copy link

Don't you go bringing reality into this @HybridDog ...

@paramat paramat deleted the waterPEC branch December 15, 2015 03:53
@HybridDog
Copy link
Contributor

ok, the real bad angel could do it with shaders l assume which would look more fancy than usual fog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants