Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borrow variable name splitting code from kep parser #40

Closed
epogrebnyak opened this issue Nov 8, 2017 · 3 comments
Closed

borrow variable name splitting code from kep parser #40

epogrebnyak opened this issue Nov 8, 2017 · 3 comments

Comments

@epogrebnyak
Copy link
Collaborator

epogrebnyak commented Nov 8, 2017

This can be a helper function in db package:

https://github.com/mini-kep/parser-rosstat-kep/blob/master/src/csv2df/util_label.py

We also need a listing of variable units of measurement descriptions, similar to #39, this can be also borrowed from here:

https://github.com/mini-kep/parser-rosstat-kep/blob/c0a4941202484127193146045a095d1fc6b2e8cc/src/csv2df/specification.py#L74-L84

@epogrebnyak
Copy link
Collaborator Author

@ignaloidas - need to import test for the functions as well

@epogrebnyak
Copy link
Collaborator Author

@ignaloidas - I suggest sticking to the rule who opend the issue - closes it, or the maintainer. It helps to keep track of if the originator person is really satisfied with what was done.

@epogrebnyak
Copy link
Collaborator Author

epogrebnyak commented Nov 11, 2017

@ignaloidas - there shoudl be a file tests/test_labels.py, the test for labels.py are mixed in test_utils.py

@epogrebnyak epogrebnyak reopened this Nov 11, 2017
epogrebnyak added a commit that referenced this issue Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants