Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run on different Erlang versions #14

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Actually run on different Erlang versions #14

merged 5 commits into from
Jan 11, 2021

Conversation

paulo-ferraz-oliveira
Copy link

No description provided.

@g-andrade
Copy link

CI is still failing in OTP 19.3, due to typing issues.

@paulo-ferraz-oliveira
Copy link
Author

CI is still failing in OTP 19.3, due to typing issues.

Yeah, I saw this. I guess these weren't exported in OTP 19.3 yet. Will just go the old MACRO-way of living, if that's the case.

@paulo-ferraz-oliveira
Copy link
Author

This is failing because of tls_certificate_check using public_key types that aren't exported. I'm going to comment unknown until we decide to move up an OTP version.

@g-andrade
Copy link

This is failing because of tls_certificate_check using public_key types that aren't exported.

Why wouldn't make checks for tls_certificate_check point this out? This crap keeps happening to me... you need to lend me your Dialyzer someday. Mine doesn't work.

@paulo-ferraz-oliveira
Copy link
Author

Why wouldn't make checks for tls_certificate_check point this out? This crap keeps happening to me... you need to lend me your Dialyzer someday. Mine doesn't work.

We're potentially not using it over the same Erlang versions (?)

@g-andrade
Copy link

We're potentially not using it over the same Erlang versions (?)

The issue has been happening to me since time immemorial. It's past any logical explanation at this point, only supernatural factors can account for it now.

@paulo-ferraz-oliveira
Copy link
Author

Tests seem to be up again. The basic problem with connectivity was running a Docker container for Erlang and a Redis service inside it. I'm now running a Ubuntu container (with no Erlang container), Redis as a service and Erlang as an installed element. It performs as expected...

@g-andrade g-andrade merged commit 847aff6 into miniclip:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants