Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Allow for duplicate document names if category is different #251

Closed
arazauci opened this issue Nov 29, 2016 · 4 comments
Closed

Allow for duplicate document names if category is different #251

arazauci opened this issue Nov 29, 2016 · 4 comments

Comments

@arazauci
Copy link

I am using doctor for creating user guides for multiple products. The products are defined as categories in doctor. Each of these products has a 'release-notes' document. However, Doctor flags this as an error because 'release-notes' already exists.

expected behavior/feature request

  • duplicate should be determined based document name + category name
  • the UI should show a some error message. currently it just highlights the field
@bekicot
Copy link

bekicot commented Dec 3, 2016

I can help to with this feature request
There is something needed to change

  1. The path. currently ,the doc path is /docs/name-of-the-docs it can be a huge change. As it will affect bookmarked link or SEO.

we can definitely create preferences for it, for example, an option for admin to set the path naming, but it will complicate the system a little bit.

Are you guys okay with the trade off ?

Correct me if i'm wrong ;)

@harshavardhana
Copy link
Member

harshavardhana commented Dec 3, 2016

I can help to with this feature request
There is something needed to change

Thanks for your interest @bekicot complicating might not be a good idea - //cc'ing @deekoder who can better articulate our reservations.

apoorv15ar added a commit to apoorv15ar/doctor that referenced this issue Dec 3, 2016
apoorv15ar added a commit to apoorv15ar/doctor that referenced this issue Dec 3, 2016
@deekoder
Copy link
Contributor

deekoder commented Dec 5, 2016

I am looking at this today.

@deekoder
Copy link
Contributor

deekoder commented Dec 5, 2016

@bekicot - Basically it is very important for us to keep the backward compatibility of having /docs/name-of-the-doc.
But I think it would be great to additionally also have /docs/category_name/name-of-the-doc if the same doc name is needed to be used under different categories. We can have preferences for it in the admin UI. We would love to see your pr proposal for such a change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants