Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcli should respect XDG basedirs for storing its configuration #3627

Closed
ddevault opened this issue Feb 27, 2021 · 11 comments
Closed

mcli should respect XDG basedirs for storing its configuration #3627

ddevault opened this issue Feb 27, 2021 · 11 comments
Assignees

Comments

@ddevault
Copy link

Is your feature request related to a problem? Please describe.

mcli should not store its configuration in the ~/.* namespace on Unix systems.

Describe the solution you'd like

mcli should respect the XDG basedirs spec, using $XDG_CONFIG_HOME/mcli if set, and falling back to ~/.config/mcli if not. It can read ~/.mcli as a last resort to avoid breaking the config for users who have already set it up, but it should not create new files there by default anymore.

@harshavardhana
Copy link
Member

This is something we can take a look but we would want to keep previous functionality so it may be good idea to have fallbacks for Linux.

@harshavardhana harshavardhana transferred this issue from minio/minio Feb 27, 2021
@klauspost
Copy link
Contributor

This will require moving the config to not break existing installs on update.

@vadmeste
Copy link
Member

This will require moving the config to not break existing installs on update.

Maybe we can do as a fallback better. I mean the last check will be ~/.mc/

@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 9, 2021
@ddevault
Copy link
Author

ddevault commented Jun 9, 2021

Don't run bots like that, jeesh

@stale stale bot removed the stale label Jun 9, 2021
@renich
Copy link

renich commented Jun 9, 2021

phew... I'm also waiting for this one.

@stale
Copy link

stale bot commented Sep 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 8, 2021
@ddevault
Copy link
Author

ddevault commented Sep 9, 2021

Don't run bots like that, jeesh

@stale stale bot removed the stale label Sep 9, 2021
@vadmeste
Copy link
Member

vadmeste commented Sep 9, 2021

I sent a PR for this. But I am not sure if we are going to merge it.

Don't run bots like that, jeesh

We receive a lot of issues and we cannot process all of them. It makes sense that a bot helps us here :)

@ddevault
Copy link
Author

ddevault commented Sep 9, 2021

Those bots are an anti-feature which communicates a lack of investment from maintainers in their community. You should triage issues and close them when you know they're not a good idea, and otherwise leave them open. Having a lot of open issues is not a mark of shame.

@harshavardhana
Copy link
Member

Those bots are an anti-feature which communicates a lack of investment from maintainers in their community. You should triage issues and close them when you know they're not a good idea, and otherwise leave them open. Having a lot of open issues is not a mark of shame.

How we manage the issues is our internal requirement, bots will run as per our requirement.

@minio minio locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants