Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion of s3 paths not working on fish at all #5037

Closed
Kakadus opened this issue Sep 18, 2024 · 3 comments
Closed

Autocompletion of s3 paths not working on fish at all #5037

Kakadus opened this issue Sep 18, 2024 · 3 comments

Comments

@Kakadus
Copy link

Kakadus commented Sep 18, 2024

Expected behavior

After having mc --autocompletion installed, completing remote s3 paths should be autocompleted.

I know there already exist #3727, but I think this is a different error. If it is really https://github.com/posener/complete, then you should issue a warning when installing autocompletion on fish (because they are broken)

Actual behavior

Only local paths are completed by fish

Steps to reproduce the behavior

  1. install autocompletion mc --autocompletion
  2. mc ls myminio/ + TAB

mc --version

  • mcli version RELEASE.2024-09-16T17-43-14Z (commit-id=11ebe952ea30e426e564f66e78d178465ae7c432)
    Runtime: go1.23.1 linux/amd64
    Copyright (c) 2015-2024 MinIO, Inc.
    License GNU AGPLv3 https://www.gnu.org/licenses/agpl-3.0.html

System information

fish, version 3.7.1

@harshavardhana
Copy link
Member

It is only tested on bash or zsh. Fish is not expected to work or neither we have the bandwidth to address it.

Feel free to send a fix if you can.

@Kakadus
Copy link
Author

Kakadus commented Sep 18, 2024

Note that https://github.com/urfave/cli/ (whose (a bit outdated) fork https://github.com/minio/cli) supports fish completions since urfave/cli#848. Maybe updating mino/cli will help?

@klauspost
Copy link
Contributor

Feel free to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants