Refactor XML handling of {set,get,delete}_bucket_notification APIs

[balamurugana]

No description provided.

[kannappanr]

LGTM

[ebozduman]

@balamurugana ,

I ran a set_bucket_notification test on my setup, and hit a TypeError:

TypeError: SubElement() argument 1 must be xml.etree.ElementTree.Element, not QueueConfig

My MinIO server is the usual stand-alone minio server, started like:
minio server <data-location>

Then I set the Redis notify configuration parameters and rebooted the minio server.

Here is the mc command, I used to set the notify configuration parameters:

$ mc admin config set myminio/ notify_redis:1 address="127.0.0.1:6379" format="namespace" key="bucketevents" password="yoursecret" queue_dir="" queue_limit="0"
Setting new key has been successful.
Please restart your server with `mc admin service restart myminio/`.

Here is the test script:

from minio import Minio
from minio.notificationconfig import (NotificationConfig, PrefixFilterRule,
                                      QueueConfig)

client = Minio(
    "localhost:9000",
    access_key="minio",
    secret_key="minio123",
    secure=False,
)

config = NotificationConfig(
    queue_config_list=[
        QueueConfig(
            "arn:minio:sqs:us-east-1:1:redis",
            ['s3:ObjectCreated:*'],
            config_id="1",
            prefix_filter_rule=PrefixFilterRule("abc"),
        ),
    ],
)

client.set_bucket_notification("bucket", config)

Running the above script throws the following error messages:

$ python3.8 run_set_bucket_notification.py 
Traceback (most recent call last):
  File "run_set_bucket_notification.py", line 47, in <module>
    client.set_bucket_notification("bucket", config)
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/api.py", line 753, in set_bucket_notification
    body = marshal(config)
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/xml.py", line 100, in marshal
    return getbytes(obj.toxml(None))
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/notificationconfig.py", line 313, in toxml
    config.toxml(config)
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/notificationconfig.py", line 219, in toxml
    element = SubElement(element, "QueueConfiguration")
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/xml.py", line 35, in SubElement
    element = ET.SubElement(parent, tag)
TypeError: SubElement() argument 1 must be xml.etree.ElementTree.Element, not QueueConfig

Please let me know if you would like to make some changes and need me to run the test.

[balamurugana]

@ebozduman fixed and updated this PR

[ebozduman]

Great! Testing it again after sync

[ebozduman]

Now, get_bucket_notification api is having another type issue:

$ python3.8 run_get_bucket_notification.py 
Traceback (most recent call last):
  File "run_get_bucket_notification.py", line 33, in <module>
    config = client.get_bucket_notification("bucket")
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/api.py", line 728, in get_bucket_notification
    return unmarshal(NotificationConfig, response.data.decode())
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/xml.py", line 85, in unmarshal
    return cls.fromxml(ET.fromstring(xmlstring))
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/notificationconfig.py", line 298, in fromxml
    queue_config_list.append(QueueConfig.fromxml(tag))
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/notificationconfig.py", line 208, in fromxml
    suffix_filter_rule) = cls.parsexml(element)
  File "/home/ersan/work/src/github.com/minio/minio-py/minio/notificationconfig.py", line 125, in parsexml
    if filter_rule.name() == "prefix":
TypeError: 'str' object is not callable

[balamurugana]

@ebozduman

Now, get_bucket_notification api is having another type issue:

Fixed and updated the PR

[ebozduman]

By the way, here is the script I use to get bucket notification configuration, if any:

from minio import Minio

client = Minio("localhost:9000",
    access_key="minio",
    secret_key="minio123",
    secure=False,
)

config = client.get_bucket_notification("bucket")
print(vars(config))

[balamurugana]

By the way, here is the script I use to get bucket notification configuration, if any:

@ebozduman There was a problem in naming unit test file caused the tests wasn't kicked in. I fixed that as well.

[ebozduman]

Tests are successfully completed.
As notification is triggered (creation of objects under bucket, "bucket", and with the name prefix "abc"), I see data coming to redis client and redis server.
LGTM