Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XML handling of {set,get,delete}_bucket_encryption APIs #991

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Refactor XML handling of {set,get,delete}_bucket_encryption APIs #991

merged 1 commit into from
Oct 23, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Oct 5, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch from 3f9e0ba to 0170bd6 Compare October 5, 2020 06:33
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch from 0170bd6 to 176f1d4 Compare October 13, 2020 16:10
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch 2 times, most recently from 6e1af5f to 46fd74d Compare October 19, 2020 10:46
ebozduman
ebozduman approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebozduman
ebozduman previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch from 46fd74d to 34db8fd Compare October 20, 2020 05:37
@balamurugana balamurugana marked this pull request as draft October 20, 2020 05:38
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch 2 times, most recently from 6f4b433 to 3be0c9d Compare October 20, 2020 14:37
@balamurugana balamurugana marked this pull request as ready for review October 20, 2020 14:40
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch from b93eb49 to 72b5f09 Compare October 20, 2020 18:33
ebozduman
ebozduman previously approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch from 72b5f09 to 3d401e6 Compare October 22, 2020 16:53
ebozduman
ebozduman approved these changes Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 36c0214 into minio:master Oct 23, 2020
@balamurugana balamurugana deleted the Refactor-XML-handling-of-set-get-delete_bucket_encryption-APIs branch October 23, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisis krisis krisis approved these changes

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @krisis @ebozduman