[CRIMAPP-911] Alter dependants grouping/banding #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| grouped_dependants['0 to 1'] += 1 | ||
| when 2, 3, 4 | ||
| when 1, 2, 3 |
There was a problem hiding this comment.
Wondering whether useful to put in a comment somewhere here to remind people that the copy refers to 'next birthday'
There was a problem hiding this comment.
Good point. I did consider that but the output literally says 'next birthday' so left it incase the wording changed and the comment was forgotten about!
arthurashman
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Alters dependants output age grouping/banding to reflect child's age at NEXT birthday
Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAPP-911
Notes for reviewer
N/A
Screenshots of changes (if applicable)
With the following ages:
Before changes:
After changes:
How to manually test the feature
Add lots of dependants in Apply, note down the ages entered.
Submit application, check in Review