Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver maintainers #629

Closed
stof opened this issue Jan 8, 2015 · 9 comments
Closed

Driver maintainers #629

stof opened this issue Jan 8, 2015 · 9 comments

Comments

@stof
Copy link
Member

stof commented Jan 8, 2015

The Mink repositories have just been moved to the minkphp organization rather than being in the Behat organization. I know need to redefine the write access to these repositories for maintainers.
However, most driver maintainers don't seem active anymore since a long time (drivers being maintained only by @aik099 and me). So before adding you to the new organization, I'm asking you whether you are still interested in this (if you are not, there is no point adding you as a maintainer):

  • @pete-otaqui for the Selenium2 driver ✅
  • @patrickdreyer for the WUnit driver ✅
  • @alexandresalome for the Selenium driver ✅
  • @b00gizm for the Zombie driver ✅
  • @66Ton99 for MinkBundle (I actually already created a team for this one before deciding to create this issue, but I can remove it if you are not interested anymore) ✅
  • @schmittjoh you have access to all (well most) repos of the Behat organization, which was including all Mink related ones before the move

Please leave a comment in this issue if you are still interested and want access (or tell us explicitly you are not). If there is no comment from you, I will assume you are not interested anymore (there is no limit in time though).

@66Ton99
Copy link

66Ton99 commented Jan 8, 2015

I am not sure how much I can help but if I would be abel to - I will help.

@b00gizm
Copy link
Contributor

b00gizm commented Jan 8, 2015

It'd be wrong to say that I'm not interested anymore, but there are things which prevent me moving forward with the Zombie driver. Most of them are compatibility issues with assaf/zombie I have reported but haven't been fixed in months. The other thing is that I personally regard the Selenium2 driver as a much better headless solution than my kinda "hacky" way with the Zombie driver.

If someone wants to take over, it's really fine for me. If no one wants, I think it might be okay to deprecate the driver in favor of other headless solution.

@stof
Copy link
Member Author

stof commented Jan 8, 2015

@b00gizm FYI, the ZombieDriver has been updated a lot by @aik099 and me recently, and it is now fully working (except for people using the form attribute on their input elements): https://travis-ci.org/minkphp/MinkZombieDriver/jobs/46294614
So I'm not in favor of deprecating it. Selenium2Driver is not really a headless solution: you need XVFB and firefox to run it (using Phantomjs as a webdriver implementation is less reliable as they have bugs in their implementation, as shown by our Travis builds)

@alexandresalome
Copy link
Contributor

Regarding my work, I would not recommend to use it. It's relying on an old
API (Selenium 1) and the underlying library is now deprecated :
https://github.com/alexandresalome/php-selenium

This driver should be deprecated in favor of Selenium2, I think.

Best regards,
Alexandre

2015-01-08 11:24 GMT+01:00 Christophe Coevoet notifications@github.com:

@b00gizm https://github.com/b00giZm FYI, the ZombieDriver has been
updated a lot by @aik099 https://github.com/aik099 and me recently, and
it is now fully working (except for people using the form attribute on
their input elements):
https://travis-ci.org/minkphp/MinkZombieDriver/jobs/46294614
So I'm not in favor of deprecating it. Selenium2Driver is not really a
headless solution: you need XVFB and firefox to run it (using Phantomjs as
a webdriver implementation is less reliable as they have bugs in their
implementation, as shown by our Travis builds)


Reply to this email directly or view it on GitHub
#629 (comment).

Alexandre Salomé
http://alexandre-salome.fr

@patrickdreyer
Copy link

Frankly speaking, I maintain as required to remove show-stoppers or to
meet my own needs.
Thus, please keep me (@patrickdreyer) as mantainer for the WUnit driver.
I'm still using the whole WUnit "stack" for BDD in combination with the
Yii Framework 1.1 on a daily basis.
As there was no need so far for me to neither upgrade to Yii 2.0 nor the
latest Behat, the somewhat outdated WUnit "stack" is still working
perfectly fine for me.
An upgrade to Yii 2.0 at some point will force me to upgrade the whole
WUnit "stack" then.

Christophe, many thanks for doing a great work and asking each of us
regarding the maintainer permissions.

Warm regards,
Patrick

Am 08.01.2015 um 01:31 schrieb Christophe Coevoet:

The Mink repositories have just been moved to the minkphp organization
rather than being in the Behat organization. I know need to redefine
the write access to these repositories for maintainers.
However, most driver maintainers don't seem active anymore since a
long time (drivers being maintained only by @aik099
https://github.com/aik099 and me). So before adding you to the new
organization, I'm asking you whether you are still interested in this
(if you are not, there is no point adding you as a maintainer):

Please leave a comment in this issue if you are still interested and
want access (or tell us explicitly you are not). If there is no
comment from you, I will assume you are not interested anymore (there
is no limit in time though).


Reply to this email directly or view it on GitHub
#629.

Patrick Dreyer
Weidstrasse 35
8932 Mettmenstetten

Mobile: +41 (76) 711 66 68 callto:+41767116668
Fix: +41 (43) 443 55 75 callto:+41434435575
Skype: PatrickDreyer skype:PatrickDreyer?call

XING https://www.xing.com/profile/Patrick_Dreyer, LinkedIn
http://ch.linkedin.com/pub/patrick-dreyer/18/52/834

@stof
Copy link
Member Author

stof commented Jan 12, 2015

@patrickdreyer you should have received the invite to the organization to get access to the WUnitDriver again

@stof
Copy link
Member Author

stof commented Jan 17, 2015

@patrickdreyer it would be great if you could reply to my questions on both issues on the driver

@pete-otaqui
Copy link
Contributor

Hi there,

I'm afraid I don't really have time to offer much maintenance to the
Selenium2 driver these days - and I'm also doing less PHP anyway.

I'm pretty happy to fork the project and make pul requests for any future
changes.

Thanks for asking, and the work that you're doing.

Pete

On 17 January 2015 at 00:48, Christophe Coevoet notifications@github.com
wrote:

@patrickdreyer https://github.com/patrickdreyer it would be great if
you could reply to my questions on both issues on the driver


Reply to this email directly or view it on GitHub
#629 (comment).

Pete Otaqui
pete@otaqui.com
+447949945542

@stof
Copy link
Member Author

stof commented Jun 16, 2015

OK, we got answers from everyone except @schmittjoh. And given he has not contributed to Mink since 2011, I guess it is safe to assume he does not need to be considered as a maintainer.
so I'm closing this issue.

@stof stof closed this as completed Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants