Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Selenium to the latest version #206

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Update Selenium to the latest version #206

merged 1 commit into from
Jul 22, 2015

Conversation

stof
Copy link
Member

@stof stof commented Mar 23, 2015

No description provided.

@aik099
Copy link
Member

aik099 commented Mar 23, 2015

OK

@stof
Copy link
Member Author

stof commented Jun 26, 2015

I updated my commit to use 2.46, and added a second commit to remove the test failing on recent versions of Selenium and not bringing much value IMO.

@stof stof mentioned this pull request Jun 27, 2015
Merged
@aik099
Copy link
Member

aik099 commented Jun 27, 2015

Please do not remove that. Fact, that CurlExec exception is now thrown and breaks the tests is a bug introduced in php-webdriver library in instaclick/php-webdriver#58 (was released as 1.4.2 version, which we might want to ignore in out composer.json) and the fix instaclick/php-webdriver#67 is pending review.

@LionsAd
Copy link

LionsAd commented Jul 22, 2015

1.4.3 was released with the patch reverted.

@LionsAd
Copy link

LionsAd commented Jul 22, 2015

So this should be good to go in

stof added a commit that referenced this pull request Jul 22, 2015
@stof
Merge pull request #206 from stof/update_selenium
3472eb8 
Update Selenium to the latest version
@stof stof merged commit 3472eb8 into minkphp:master Jul 22, 2015
@stof stof deleted the update_selenium branch July 22, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stof @aik099 @LionsAd