select.poll timeout is in milliseconds #26

minrk · 2018-12-12T12:23:03Z

select.select uses seconds, which is what self.flush_timeout used

I believe this is the cause of the occasional failures after switching to select.poll

select was in seconds, so we need to multiply by 1000 here

flushing stdout doesn't guarantee its arrival before stderr because they could arrive in the same tic

minrk added 2 commits December 12, 2018 13:21

poll timeout is in milliseconds

9d54099

select was in seconds, so we need to multiply by 1000 here

flush stderr after writing

6a71ae6

minrk force-pushed the poll-timeout branch from d4eb3d4 to 6a71ae6 Compare December 12, 2018 12:42

sleep after flushing stdout

92b374b

flushing stdout doesn't guarantee its arrival before stderr because they could arrive in the same tic

minrk merged commit 75ee16a into master Dec 12, 2018

minrk deleted the poll-timeout branch December 12, 2018 13:12

Provide feedback