use Bytes/StringIO for pipes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
full-buffers
branch
2 times, most recently
from
a8bdfc9
to
ad12d14
Compare
avoids buffer size issues backward compatibility issue: before this, output could be read while inside the context manager, (and must be for large output to avoid blocking) while after it can only be read reliably after the context has finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids buffer size issues (closes #48)
backward compatibility issue: before this, output could be read while inside the context manager, (and must be for large output to avoid blocking) while after it can only be read reliably after the context has finished.
We could try to use a more sophisticated approach that preserves both - infinite buffer size and safe read/write order, but this is the simplest fix that I think should work in all real-world cases.