Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Format Command Exception If Pattern Not Valid #157

Merged
merged 4 commits into from
Jan 11, 2020
Merged

Handle Format Command Exception If Pattern Not Valid #157

merged 4 commits into from
Jan 11, 2020

Conversation

s0kil
Copy link
Contributor

@s0kil s0kil commented Jan 10, 2020 

$ mint format tests/
Mint - Formatting files
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Unhandled exception: Error reading file: Is a directory (Errno)
Failed to raise an exception: END_OF_STACK
[0x564504d061a6] ???
[0x56450497e42b] __crystal_raise +43
[0x56450497ecd5] ???
[0x56450498b1ad] ???
[0x56450498373c] ???
[0x564504983163] ???
[0x564504a0c1b5] ???
[0x56450499765a] ???
[0x564504980eb7] main +55
[0x7ff3b65461e3] __libc_start_main +243
[0x564504901cde] _start +46
[0x0] ???

s0kil
s0kil commented Jan 10, 2020
View reviewed changes
src/commands/format.cr Outdated Show resolved Hide resolved
Sija
Sija reviewed Jan 10, 2020
View reviewed changes
src/commands/format.cr Outdated Show resolved Hide resolved
@s0kil
Copy link
Contributor Author

s0kil commented Jan 10, 2020

Getting used to Git

Sija
Sija reviewed Jan 10, 2020
View reviewed changes
src/commands/format.cr Outdated Show resolved Hide resolved
src/commands/format.cr Outdated Show resolved Hide resolved
@s0kil
Copy link
Contributor Author

s0kil commented Jan 10, 2020

Looks Good To Go.

@gdotdesign gdotdesign merged commit 39dae3e into mint-lang:master Jan 11, 2020
@gdotdesign
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s0kil @gdotdesign @Sija