Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile external assets into their own files. #183

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Conversation

gdotdesign
Copy link
Member

This PR resolves issues with packages having external files:

  • external javascripts are now compiled into a single file external-javascripts.js (in development and build)
  • external stylesheets are now compiled into a single file external-stylesheets.css (in development and build)
  • external files are no longer being restricted to the public directory

With the change of #155 the following issues cropped up:

  • packages could not serve their external stylesheets in development because we relied on them being in the public directory
  • having restrict external files into the public directory made it impossible to reference files outside of the project. To give this more context: I'm working on mint-ui and mint-ui-showcase, I needed to access a JavaScript file which is mint-ui from mint-ui-showcase as (../mint-ui/assets/scroll_into_view.js) and this was not possible

src/reactor.cr Outdated Show resolved Hide resolved
@gdotdesign gdotdesign merged commit 94dce39 into master Feb 17, 2020
@gdotdesign gdotdesign deleted the external-files branch February 26, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants