-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to CSS classes #349
Add prefix to CSS classes #349
Conversation
I totally agree for the alternative design. This one is just a workaround. I have seen some CSS framework which had classnames like EDIT: I propose to make a configuration variable inside the |
I may try, do you have any hint for using variables from the |
@gdotdesign can you advise? |
I need to find a way to get values from This class shouldn't read the json directly because it creates an unnecessary coupling. |
I like the idea of having a prefix for this, however my personal choice would be command line flag, but the Code wise we should can pass the it from the top level command to the compiler itself. |
I don't know why, but on my personal app, I don't have any html, but from manual test, and from specs, it works. Can someone help me to find out why? |
a
to aa
I'm confused because |
It's because the prefix contains a dash
and this causes a JavaScript error. What we need to do is to just use the un-prefixed version internally (in JavaScript) and use the prefixed one for the actual classes. |
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
🎉 Thanks for the fix ! |
Description
This fix the possibility to have a conflict between external CSS and Mint CSS.
Most of external css are compiled and use letter as identifier (as mint does).
Skipping the 26 first reduce the chance that an important style apply.It allows the user to specify a specific prefix for css classes.