Check dependency availability before building #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
manveru
commented
Jun 20, 2018
•
manveru
commented
manveru
force-pushed
the
check-missing-dependencies
branch
from
fd1a4a3
to
dbf868f
Compare
gdotdesign
reviewed
Jun 20, 2018
src/builder.cr
Outdated
| @json = MintJson.parse_current | ||
|
|
||
| terminal.measure "#{COG} Ensuring dependencies... " do | ||
| json.check_dependencies!(sources) |
There was a problem hiding this comment.
Passing the sources are not needed since the json knows about it's directory so it's calculable from there, or might not be needed at all (see last comment).
src/macros.cr
Outdated
| @@ -19,6 +19,16 @@ module Mint | |||
| end | |||
| end | |||
|
|
|||
| class Builder | |||
| macro build_error(name) | |||
There was a problem hiding this comment.
I think it's not used anymore.
src/mint_json.cr
Outdated
| end | ||
|
|
||
| def dependency_exists?(sources : Array(String), name : String) | ||
| pattern = /\.mint\/packages\/#{name}\/source/ |
There was a problem hiding this comment.
- the
sourcedirectory might not be present for every package since it's configurable viasource-directories - I think at this point since we don't have a lock file It's enough to check if there is a directory for the package, then the sources are not even needed here
- once we have a lock file then we can do a more thorough check
manveru
force-pushed
the
check-missing-dependencies
branch
from
4b343e5
to
d1fec70
Compare
manveru
changed the title
mint build
manveru
force-pushed
the
check-missing-dependencies
branch
from
d1fec70
to
cdec617
Compare
|
@gdotdesign alright, cleaned it up a lot by simply checking the directory. I'd really like to not involve a lot of I/O during these phases, that's why I went with the sources approach, but maybe that can improved in the future as you say. |
gdotdesign
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.