Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run core specs on both, firefox and chrome browsers #429

Merged
merged 2 commits into from
May 22, 2021

Conversation

Sija
Copy link
Member

@Sija Sija commented May 21, 2021

No description provided.

@Sija Sija added the tooling Tooling related feature (formatter, documentation, production builder) label May 21, 2021
@Sija Sija changed the title Run core specs on firefox _and_ chrome browsers [CI] Run core specs on both, firefox and chrome browsers May 21, 2021
@Sija
Copy link
Member Author

Sija commented May 22, 2021

@gdotdesign I see couple of ways how we can approach these 2 failing tests:

  1. Fix the tests, so they'd succeed on chrome
  2. Add an approach of running the tests conditionally - only/except on some browsers
  3. Remove/Comment out the tests
  4. Use continue-on-error: true and just ignore 'em

I'd lean towards option 1 if possible, and option 3 otherwise.

@gdotdesign
Copy link
Member

I think we can remove those tests for now since the methods work just not in that context, after that we can try to create something that works in Chrome using maybe dispatchEvent.

@Sija Sija merged commit d752f5c into master May 22, 2021
@Sija Sija deleted the ci-run-core-specs-on-chrome-too branch May 22, 2021 15:47
@gdotdesign gdotdesign added this to the 0.13.0 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tooling related feature (formatter, documentation, production builder)
Development

Successfully merging this pull request may close these issues.

2 participants