Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read repository without .git extension #77

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Read repository without .git extension #77

merged 2 commits into from
Aug 28, 2018

Conversation

s0kil
Copy link
Contributor

@s0kil s0kil commented Aug 26, 2018

Seems unnecessary to modify mint.json repository URL to contain .git. Currently more user friendly

@gdotdesign gdotdesign merged commit cd9fee3 into mint-lang:master Aug 28, 2018
@@ -18,6 +18,10 @@ module Mint
@target : String | Nil

def self.open(name = "", url = "", target = nil, version = nil)
if url.includes?("http") && !url.ends_with?(".git")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes? -> starts_with?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will be better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants