Improve parser for block-comment #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdotdesign
requested changes
Sep 5, 2018
There was a problem hiding this comment.
The initial implementation looks great 👍
However its not complete:
- there is no AST node for inline comment so parsed inline comments would be formatted as block comments by the formatter
- as commented in the code, changes are needed to allow inline comments to work across all of the language
We could break up the two features into separate PRs, because the block-comment parser improvements could be merged right now.
src/parsers/component.cr
Outdated
| @@ -7,7 +7,7 @@ module Mint | |||
|
|
|||
| def component : Ast::Component | Nil | |||
| start do |start_position| | |||
| comment = self.comment | |||
| comment = self.comment || self.inline_comment | |||
There was a problem hiding this comment.
There are a lot of places where the comment function is called. Adding || self.inline_comment to each would not be a good solution.
Probably we should:
- rename the
commentfunction toblock_comment - create a new
commentfunction which parses ablock_commentor aninline_comment - rename the
Ast::Commentnode toAst::BlockCommentand create an alias:alias Comment = BlockComment | InlineComment
Then all current related code would work unchanged.
|
Thanks for the review, @gdotdesign! Okay. I will update this PR. For the #81, it will be on separated PR. |
gdotdesign
approved these changes
Sep 5, 2018
wisn
changed the title
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why improve block-comment parser? The block-comment will breaks if we do these below.
Please review @gdotdesign