Update v3.0.0's changelog sentry example #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 93.51% 93.52%
=======================================
Files 17 18 +1
Lines 694 695 +1
=======================================
+ Hits 649 650 +1
Misses 45 45
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). | |||
| - Add type hints | |||
| - Increase test coverage | |||
| - Bugfix: lpipe.sqs.delete_message_batch called boto3 incorrectly | |||
| - Breaking: sentry-sdk no longer a required dependency, install with `lpipe = {"extras": ["sentry"], "version": "*"}`, and enable it by setting `process_event(exception_handler=lpipe.contrib.sentry.capture)` | |||
| - Breaking: sentry-sdk no longer a required dependency, install with `lpipe = {extras: ["sentry"], version: "*"}`, and enable it by setting `from lpipe.contrib import sentry ... process_event(exception_handler=sentry.capture)` | |||
There was a problem hiding this comment.
from lpipe.contrib import sentry; process_event(exception_handler=sentry.capture)
|
Improvement in this PR #20 |
charlieparkes
changed the title
|
#20 fixed this, but feel free to use this PR to fix the extras example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.