Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate payload paths and queues #23

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

charlieparkes
Copy link
Collaborator

@charlieparkes charlieparkes commented Jun 16, 2020

Change Payload to split paths into paths and queues. Update all logic to assume only path strings / enums are in payload.paths.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #23 into master will decrease coverage by 0.25%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   93.55%   93.29%   -0.26%     
==========================================
  Files          18       18              
  Lines         698      716      +18     
==========================================
+ Hits          653      668      +15     
- Misses         45       48       +3     
Impacted Files Coverage Δ
lpipe/payload.py 88.00% <76.92%> (-12.00%) ⬇️
lpipe/pipeline.py 87.39% <97.87%> (+0.61%) ⬆️
lpipe/action.py 100.00% <100.00%> (ø)
lpipe/normalize.py 91.66% <100.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544443e...18cf987. Read the comment docs.

@charlieparkes charlieparkes merged commit db13f45 into master Jun 30, 2020
@charlieparkes charlieparkes deleted the separate_payload_paths_and_queues branch July 6, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant