Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventSourceType and parse_event() generator #30

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

charlieparkes
Copy link
Collaborator

@charlieparkes charlieparkes commented Jul 13, 2020

Represent event source type as EventSourceType instead of using QueueType everywhere. Generate records from event using generator parse_event()

event_source_type = lpipe.EventSourceType.SQS

for encoded_record, decoded_record, event_source in parse_event(event, event_source_type):
    print(decoded_record)

…Type everywhere. Generate records from event using generator parse_event()
@charlieparkes charlieparkes self-assigned this Jul 13, 2020
@charlieparkes charlieparkes linked an issue Jul 13, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #30 into master will decrease coverage by 0.14%.
The diff coverage is 89.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   93.40%   93.26%   -0.15%     
==========================================
  Files          18       18              
  Lines         728      742      +14     
==========================================
+ Hits          680      692      +12     
- Misses         48       50       +2     
Impacted Files Coverage Δ
lpipe/pipeline.py 87.92% <88.88%> (-0.08%) ⬇️
lpipe/__init__.py 100.00% <100.00%> (ø)
lpipe/queue.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc21d5...3af8606. Read the comment docs.

@charlieparkes charlieparkes merged commit 4c02a9c into master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for API to parse event
1 participant