Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you have two different versions #1

Closed
orefalo opened this issue Jul 7, 2021 · 2 comments
Closed

Why do you have two different versions #1

orefalo opened this issue Jul 7, 2021 · 2 comments

Comments

@orefalo
Copy link

orefalo commented Jul 7, 2021

Hi, thank yo for this pkg.

Why do you have two different versions

@confiks
Copy link
Contributor

confiks commented Jul 7, 2021

For the Dutch variant of the green pass using unlinkable signatures [1][2], we need all the space we can get, so we use a base45 encoding that uses the exact same method as base58 [3], and which has the exact same efficiency as QR binary mode.

The EU variant isn't of the same efficiency as QR binary mode, as it converts 3 bytes into 2 base45 characters. So it's more like 'base41 using the base45' charset.

[1] https://github.com/minvws/nl-covid19-coronacheck-app-coordination/blob/main/architecture/Privacy%20Preserving%20Green%20Card.md

[2] https://github.com/minvws/nl-covid19-coronacheck-idemix

[2] https://gist.github.com/confiks/8fcb480d87a50cf1bb5e40e2f0930fad

@orefalo
Copy link
Author

orefalo commented Jul 7, 2021

Thank you so much. Neat implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants