New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIP 核心错误依赖了组件 polyfill #413

Closed

yenshih opened this issue Dec 12, 2018 · 2 comments

Assignees

Labels

browser quirks bug has PR

Contributor

yenshih commented Dec 12, 2018 •

edited

Loading

BUG 描述

mip-bind 依赖 ES6 特性 Set
Set 的 polyfill 位于 __mipComponentsWebpackHelpers__

复现步骤

将 installMipComponentsPolyfill 移至 mip-bind 注册后执行
根据 phantomjs 环境下报错 #402 复现的 phantomjs 环境报错，低端机应该也会报错

期望结果

installMipComponentsPolyfill 仅用于组件依赖

The text was updated successfully, but these errors were encountered:

yenshih added bug browser quirks labels

PengXing assigned yenshih

yenshih mentioned this issue

【免测】移除 mip-bind 依赖的 Set 特性 #420

Merged

6 tasks

Contributor Author

yenshih commented Dec 17, 2018 •

edited

Loading

修复方案

移除 mip-bind 中的 Set，移除 Set 的 polyfill
__mipComponentsWebpackHelpers__ 使用更严格的 babel-runtime 白名单 @clark-t
核心 [...arr] 依赖 Array.from 的 polyfill，需保留
其他 polyfill 可移至组件注册前（至少需回归 phantomjs）
在 12.31 后继续推进

yenshih added the has PR label

yenshih changed the title ~~mip-bind 依赖 ES6 特性 Set~~ MIP 核心错误依赖了组件 polyfill

Contributor Author

yenshih commented Jan 10, 2019 •

edited

Loading

关于 __mipComponentsWebpackHelpers__ 的问题在新的 issue 继续跟进

yenshih closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment