-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIP 核心中移除 Vue 代码 #357
Merged
Merged
MIP 核心中移除 Vue 代码 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1099
💛 - Coveralls |
huanghuiquan
approved these changes
Nov 28, 2018
|
||
holder.script = this.insertScript(this.getExtensionScriptUrl(extensionId, version)) | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些注释掉的代码删掉?感觉留着增加心理负担
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
留着吧,preloadDeps
的时候还是有用的
gaoshan003
approved these changes
Nov 29, 2018
PengXing
added a commit
that referenced
this pull request
Apr 29, 2019
* fix: 修复核心全量后已知 bugs (#546) * fix: mip 链接使用默认行为 (#548) * fix: Register built-in components when document interactive (#555) * fix: Fix external resources protocol (#558) * feat: 增强 templates 判断逻辑 (#567) * 新增 mip 前端小流量机制 (#560) * feat: 新增 mip 前端小流量机制 * 修改注释 * 调整变量名和 cookie 的失效时间 * fixed: 无需在 js 中指向 mip cahce url * mip.js 沙盒对象增加 BMap\BMapLib (#577) * 增加 sandbox 白名单 * 将 BMap 改成 readywrite * 升级 mip.js 核心的 sandbox * MIP 核心中移除 Vue 代码 (#357)
clark-t
added a commit
that referenced
this pull request
May 7, 2019
* mip 核心升级 babel v7 * 去除多余配置和模块 * 删掉多余注释 * 更新 mip-compoenents-webpack-helpers * 将 css-loader 锁在0.28 * fix: 修复核心全量后已知 bugs (#546) * 增加 symbol 的 polyfill * 增加注释 * fix: mip 链接使用默认行为 (#548) * 把 symbol 加上 * lock babel version * add component helper version * 升级 component helpers 版本 * fix: Register built-in components when document interactive (#555) * fix: Fix external resources protocol (#558) * 修改test case * 修改 test case * add sleep * feat: 增强 templates 判断逻辑 (#567) * 新增 mip 前端小流量机制 (#560) * feat: 新增 mip 前端小流量机制 * 修改注释 * 调整变量名和 cookie 的失效时间 * fixed: 无需在 js 中指向 mip cahce url * mip.js 沙盒对象增加 BMap\BMapLib (#577) * 增加 sandbox 白名单 * 将 BMap 改成 readywrite * 升级 mip.js 核心的 sandbox * update * add promise finally polyfill * 挪个位置 * 消除其他影响 * change position * recover test case * readd maintemplate * MIP 核心中移除 Vue 代码 (#357) * mip-img 支持调起手百图片浏览器 (#587) * mip-img 支持调起手百图片浏览器 * fix: Fix base url calculation (#590) * update helper * update helper * 修改 mip-img 手百调起逻辑 (#592) * 修改调起逻辑 * mip-img 修复滑动调起 (#597) * 修复滑动调起
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
相关 ISSUE: #346
1、升级点
vue-custom-element
及vue
的相互依赖mip.js
同目录下,单独打包出一个mip-vue.js
mip-vue.js
,详细情况见 MIP 核心中移除 Vue 代码 #3462、影响范围 (描述该需求上线会影响什么功能)
mip-vue.js
的请求和执行完成后才能渲染3、自测 Checklist
4、需要覆盖的场景和 Case
5、自测机型和浏览器