Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIP 核心中移除 Vue 代码 #357

Merged
merged 22 commits into from
Apr 29, 2019
Merged

MIP 核心中移除 Vue 代码 #357

merged 22 commits into from
Apr 29, 2019

Conversation

yenshih
Copy link
Contributor

@yenshih yenshih commented Nov 26, 2018

相关 ISSUE: #346

1、升级点

  • 移除核心与 vue-custom-elementvue 的相互依赖
  • mip.js 同目录下,单独打包出一个 mip-vue.js
  • 注册 extension 时,如果出现 vue 组件,按需动态插入 mip-vue.js,详细情况见 MIP 核心中移除 Vue 代码 #346

2、影响范围 (描述该需求上线会影响什么功能)

  • MIP 核心体积减小 25%
  • Vue 组件渲染性能降低,需等待 mip-vue.js 的请求和执行完成后才能渲染

3、自测 Checklist

  • 已测试官网,与预期一致

4、需要覆盖的场景和 Case

  • 是否覆盖了 sf 打开 MIP 页
  • 是否验证了极速服务 MIP 页面效果

5、自测机型和浏览器

  • 是否覆盖了 iOS 系统手机
  • 是否覆盖了 Android 系统手机
  • 是否覆盖了 iPhone 版式浏览器(比如 QQ、UC、Chrome、Safari、安卓自带浏览器)
  • 是否覆盖了手百

@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 1099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.373%

Totals Coverage Status
Change from base Build 1081: 0.02%
Covered Lines: 3824
Relevant Lines: 3964

💛 - Coveralls


holder.script = this.insertScript(this.getExtensionScriptUrl(extensionId, version))
}
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些注释掉的代码删掉?感觉留着增加心理负担

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

留着吧,preloadDeps 的时候还是有用的

@gaoshan003
Copy link

gaoshan003 commented Nov 29, 2018

业务回归
小说:chrome模拟
Query=雪中悍刀行

  1. 点击小说页面内部的上一页和上一页(前后5页),查看小说页面和广告页面展示正常,common请求发送正常
  2. 点击小说阅读器的上一页和下一页(前后5页),查看小说页面和广告页面展示正常,common请求发送正常
  3. 点击章节目录进入小说页,查看小说页面和广告页面展示正常,common请求发送正
  4. 点击章节目录进入小说页,然后点击小说页面内部的上一页和上一页(前后5页),查看小说页面和广告页面展示正常,common请求发送正常
  5. 点击章节目录进入小说页,然后点击小说阅读器的上一页和下一页(前后5页),查看小说页面和广告页面展示正常,common请求发送正常
    小说Checklist正常

服务:Chrome模拟
Query=搬家

  1. 从结果页点击进入服务页面,加载正常、服务shell头部显示正常
  2. 服务页首页二跳跳转正常,页面显示正常,点击后退正常跳转到首页
  3. 点击首页菜单栏中关于服务,跳转正常,点击后退正常跳转到首页
  4. 再次从首页跳转到下一页后,页面划动正常,点击头部菜单栏中首页,正常跳转到首页,点击首页shell头部叉按钮,正常退出到结果页,且结果页滑动正常
  5. 同步刷新页面,页面显示正确,头部shell显示正常

Feed导流页面显示正常
医疗
https://sjh.baidu.com/site/wzyya.com/626be369-37a2-48d2-af79-180ab0c30876
营销
https://sjh.baidu.com/site/china3561.com/5f946143-651d-40f7-9e1e-014827e8bb3b
电商
https://sjh.baidu.com/site/t.asdht.com/12f90005-65a1-4e4c-bfdb-346f9d33b580

服务中心内的服务测试

按流量覆盖mip2站点测试
http://cp01-sys-rpm14.cp01.baidu.com:8003/wishwing/c/www.xmkanshu.com/book/mip/read%3Ffr%3Dxs_aladin_free%26bkid%3D685640121%26mip%3D1%26crid%3D657?novel=1&word=%E5%85%83%E5%B0%8A&title=%E5%85%83%E5%B0%8A&lid=8219029002694252415&referlid=8219029002694252415&ms=1&frsrcid=65&frorder=1&s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/wishwing/c/s/wenxue.m.iqiyi.com/act/nocache/mipReader-18l2gzysex-18l25r7gmr.html%3Fbaiduvs%3D206045739%26page%3D3?novel=1&word=&title=&lid=11814320723697687875&referlid=11814320723697687875&ms=1&frsrcid=5064&frorder=2&s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.cr173.com/mipx/776254.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/mip.findlaw.cn/ask/question_45211776.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.qqtn.com/mipc/234131.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.meishichina.com/ingredient/ShengHao/?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/m.5h.com/mipw/mr/34008.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.ruan8.com/mipyx/18552.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/m.diyiyou.com/mipxz/46359.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/app.3dmgame.com/mip/gl/56973.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/m.maiche.com/mip/news/detail/1496816.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.hunliji.com/bai_ke/detail_21610?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/s/m.anruan.com/mipyx_g47737.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/mip.downza.cn/xy/3517.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/m.eoemarket.com/apps/show/id/651129?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/wishwing/c/s/mys4s.cn/static/vio/xz/index.html%3Fcurrent=2?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/ala/c/s/www.mipengine.org/?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/mip/c/m.1688.com/mip/qingqu/-C8E9CEFCC4D0D7D4CEBFC6F7.html?s_j=1
http://cp01-sys-rpm14.cp01.baidu.com:8003/wishwing/c/s/www.lanxiniu.com/BaiduMip/order?s_j=1

小说雪中悍刀行和搬家兼容性覆盖
IOS 10、IOS11、安卓4、安卓8 服务
Ios7 iphone4s uc safari 小说 服务
Ios9 uc safari 简搜 手百 qq 服务 小说
Android7 Samsung_SM-g9200 uc 自带 简搜 手百 qq chrome 小说
Ios11 uc 手百 safari chrome 小说
Android4 uc、chrome、简搜 小说
Android6 HUAWEI NXT-AL uc chrome 自带 小说

测试发现一个bug,已修复,测试通过

@yenshih yenshih merged commit 01246ed into dev Apr 29, 2019
PengXing added a commit that referenced this pull request Apr 29, 2019
* fix: 修复核心全量后已知 bugs (#546)

* fix: mip 链接使用默认行为 (#548)

* fix: Register built-in components when document interactive (#555)

* fix: Fix external resources protocol (#558)

* feat: 增强 templates 判断逻辑 (#567)

* 新增 mip 前端小流量机制 (#560)

* feat: 新增 mip 前端小流量机制

* 修改注释

* 调整变量名和 cookie 的失效时间

* fixed: 无需在 js 中指向 mip cahce url

* mip.js 沙盒对象增加 BMap\BMapLib (#577)

* 增加 sandbox 白名单

* 将 BMap 改成 readywrite

* 升级 mip.js 核心的 sandbox

* MIP 核心中移除 Vue 代码 (#357)
clark-t added a commit that referenced this pull request May 7, 2019
* mip 核心升级 babel v7

* 去除多余配置和模块

* 删掉多余注释

* 更新 mip-compoenents-webpack-helpers

* 将 css-loader 锁在0.28

* fix: 修复核心全量后已知 bugs (#546)

* 增加 symbol 的 polyfill

* 增加注释

* fix: mip 链接使用默认行为 (#548)

* 把 symbol 加上

* lock babel version

* add component helper version

* 升级 component helpers 版本

* fix: Register built-in components when document interactive (#555)

* fix: Fix external resources protocol (#558)

* 修改test case

* 修改 test case

* add sleep

* feat: 增强 templates 判断逻辑 (#567)

* 新增 mip 前端小流量机制 (#560)

* feat: 新增 mip 前端小流量机制

* 修改注释

* 调整变量名和 cookie 的失效时间

* fixed: 无需在 js 中指向 mip cahce url

* mip.js 沙盒对象增加 BMap\BMapLib (#577)

* 增加 sandbox 白名单

* 将 BMap 改成 readywrite

* 升级 mip.js 核心的 sandbox

* update

* add promise finally polyfill

* 挪个位置

* 消除其他影响

* change position

* recover test case

* readd maintemplate

* MIP 核心中移除 Vue 代码 (#357)

* mip-img 支持调起手百图片浏览器 (#587)

* mip-img 支持调起手百图片浏览器

* fix: Fix base url calculation (#590)

* update helper

* update helper

* 修改 mip-img 手百调起逻辑 (#592)

* 修改调起逻辑

* mip-img 修复滑动调起 (#597)

* 修复滑动调起
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants