Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precompile (and hence testing) slowdown #994

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix precompile (and hence testing) slowdown #994

merged 1 commit into from
Apr 19, 2023

Conversation

unzvfu
Copy link
Contributor

@unzvfu unzvfu commented Apr 19, 2023

Replace %stack calls with equivalent opcodes.

The sequence of opcodes was actually generated by the %stack macro expander function, then substituted in at the call site.

@unzvfu unzvfu requested a review from wborgeaud April 19, 2023 14:19
@unzvfu unzvfu self-assigned this Apr 19, 2023
wborgeaud
wborgeaud approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unzvfu unzvfu merged commit 2e16ab0 into main Apr 19, 2023
@unzvfu unzvfu deleted the hamish/fix-precompile-slowdown branch April 19, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborgeaud wborgeaud wborgeaud approved these changes

Assignees

@unzvfu unzvfu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unzvfu @wborgeaud