feat(Apple Music): Automated Authentication #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since freyr doesn't use custom-generated Apple Music tokens, and instead opts for the one embedded in the music.apple.com website, these tokens typically have a validity period of 3 months or under.
Making it so we have to update these tokens rather frequently, which is not ideal for persistence.
#590 highlights a pattern for extracting the token from the website, and this patch automates that, merging it right into freyr's authentication logic.
Now, we no longer need a
developerToken
inconf.json
as it would be fetched from the Apple Music website on the first-run.And any subsequent token updates when expired will be updated with the same process.
Making sure, we never have any periods of unauthentication past this point.