Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from 3.5.1 release #2167

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Updates from 3.5.1 release #2167

merged 3 commits into from
Jan 11, 2023

Conversation

metanivek
Copy link
Member

This PR is bringing changes that came up during the 3.5.1 release (#2162), either in testing or during the opam CI process.

Store.integrity_check ~ppf:Format.err_formatter ~auto_repair ~heads repo
in
let+ () = Store.Repo.close repo in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only the bug fixer here -- Victor found it during his testing!

@adatario
Copy link
Contributor

For future reference this is why tests are disabled on macos: ocaml/opam-repository#22837 (comment)

@metanivek
Copy link
Member Author

@adatario thanks for adding that link. For more context, the tests were failing for the same reason that libirmin fails, namely this bug. It has been a constant source of headache for us. If I had a mac I would definitely look into fixing it.

@metanivek metanivek merged commit ff45092 into mirage:main Jan 11, 2023
@metanivek metanivek deleted the 351_fixes branch January 11, 2023 14:35
@clecat clecat self-requested a review January 11, 2023 15:33
Copy link
Contributor

@clecat clecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thx for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants