irmin-pack: add gc cleanup for lower layer #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use volume identifier instead of root string (even though they are in practice the same thing) and move swap code into the Lower module for future usage with cleanup.
27 tasks
Firobe
approved these changes
Mar 22, 2023
Comment on lines
+147
to
+148
| | [ "volume"; g; "control" ] when is_number g -> | ||
| `Control_tmp (int_of_string g) |
There was a problem hiding this comment.
Thanks for this! It seems I forgot to do it earlier.
Handles the appendable volume control file from a GC: 1. If a control file matches the generation of the upper layer control file, it is renamed to become the current control file. 2. Otherwise, it is unlinked.
metanivek
force-pushed
the
lower_gc_cleanup
branch
from
bef2161
to
ba8aecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the cleanup code for the lower layer in the situation where GC fails, either in the worker or during finalization. I also did some light refactoring to co-locate the swap and cleanup functions in the
Lowermodule.