Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix request structure #112

Merged
merged 1 commit into from
May 9, 2024
Merged

fix request structure #112

merged 1 commit into from
May 9, 2024

Conversation

palainp
Copy link
Member

@palainp palainp commented May 9, 2024

Fix a issue spotted with qubes-mirage-firewall (in mirage/qubes-mirage-firewall#193).

@hannesm
Copy link
Member

hannesm commented May 9, 2024

Thanks, I just prepared an identical commit :)

@palainp
Copy link
Member Author

palainp commented May 9, 2024

I'm lucky luke :)

@hannesm
Copy link
Member

hannesm commented May 9, 2024

I opened ocaml/opam-repository#25822 so that there won't be many people suffering from the bad release.

@hannesm hannesm merged commit ea6b8c0 into mirage:main May 9, 2024
1 check passed
hannesm added a commit to hannesm/opam-repository that referenced this pull request May 9, 2024
CHANGES:

* Fix TX.Request structure decoding and encoding (introduced in 2.1.4, mirage/mirage-net-xen#110 --
  fixed by @palainp mirage/mirage-net-xen#112) -- due to this bug, 2.1.4 is marked as unavailable
  in opam-repository
@hannesm
Copy link
Member

hannesm commented May 9, 2024

thanks, merged and released 2.1.5 to opam-repository

@palainp palainp deleted the fix-tx branch May 9, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants